Opened on 03/13/2014 at 09:21:25 AM
Last modified on 10/08/2014 at 11:21:43 AM
#127 new change
Make checkbox descriptions in Android describe the action, not show the current status
Reported by: | philll | Assignee: | |
---|---|---|---|
Priority: | P5 | Milestone: | |
Module: | Adblock-Plus-for-Android | Keywords: | |
Cc: | fhd | Blocked By: | |
Blocking: | Platform: | Android | |
Ready: | yes | Confidential: | no |
Tester: | Verified working: | no | |
Review URL(s): |
Description
Background
Making checkbox descriptions in Android describe the action, not show the current status is persistent with how Android itself uses checkbox description texts, e.g. "Unknown Sources" under "Security".
What to change
Make checkbox descriptions in Android describe the action, not show the current status
Attachments (0)
Change History (4)
comment:1 Changed on 03/13/2014 at 09:21:42 AM by philll
comment:2 Changed on 04/07/2014 at 10:00:31 AM by fhd
- Priority changed from Unknown to P5
- Ready unset
We're not really sure if we want this yet, so P5.
comment:3 Changed on 05/09/2014 at 03:51:48 PM by philll
- Cc fhd added
Apparently, the labels are currently not even a real status description, as the case of acceptable ads shows:
If AA are turned on, the label is "Allow some non-untrusive advertising"
If AA is turned off, the label is "Block all advertising"
I would be fine with obvious status descriptions like "All ads blocked" or "Some non-intrusive ads allowed" but the current mixture of action-like and status-like description makes the whole thing very confusing.
@fhd: let's discuss this issue and come to an acceptable conclusion.
comment:4 Changed on 10/08/2014 at 11:21:43 AM by rjeschke
- Platform set to Android
- Ready set
by Andrey Novikov: Can not agree, it will be inconsistent with our other checkboxes. May be it's better use more descriptive texts like in advanced settings?