Opened on 08/27/2014 at 09:45:47 AM
Closed on 08/27/2014 at 01:57:23 PM
#1273 closed defect (fixed)
WebKit misoptimizations strike again: Overridden getters are called on Safari 8
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-1.8.4-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Safari | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description (last modified by sebastian)
Environment
Safari 8 / Mac OS X Yosemite
Observed behaviour
Randomly, some ads aren't blocked, while the log of the global page is flooded with errors indicating that the readonly properties RegExpFilter.regexp and ActiveFilter.domains are attempted to be redefined.
The reason is WebKit bug 132872, which we previously worked around with #419. However it seems that Safari 8 does more aggressive optimizations, rendering our current workaround insufficient.
Expected behaviour
Ads should be always blocked when Adblock Plus is active. No unhandled JavaScript errors should occur.
Attachments (0)
Change History (3)
comment:1 Changed on 08/27/2014 at 09:48:25 AM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 08/27/2014 at 11:30:23 AM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Priority changed from P2 to P1
comment:3 Changed on 08/27/2014 at 01:57:23 PM by sebastian
- Description modified (diff)
- Resolution set to fixed
- Status changed from reviewing to closed
- Summary changed from WebKit misoptimazions strike again: Overridden getters are called on Safari 8 to WebKit misoptimizations strike again: Overridden getters are called on Safari 8
Note: See
TracTickets for help on using
tickets.
https://hg.adblockplus.org/adblockplus/rev/10df3dfad74f
https://hg.adblockplus.org/adblockpluschrome/rev/e7a439a7f672