Opened on 08/28/2014 at 10:35:16 PM

Closed on 06/19/2015 at 07:16:16 PM

#1284 closed change (fixed)

Remove id from AppInfo

Reported by: fhd Assignee: Mailkov
Priority: P3 Milestone:
Module: Libadblockplus Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​https://github.com/adblockplus/libadblockplus/pull/2

Description

Background

We don't need AppInfo::id. In Firefox, this field is used for the addon ID, on other platforms it is irrelevant.

What to change

Remove the id member variable from AppInfo.

Attachments (0)

Change History (6)

comment:1 Changed on 05/20/2015 at 11:15:17 AM by Mailkov

Hi, I would like to work on this!!

comment:2 Changed on 05/20/2015 at 11:34:24 AM by Mailkov

pull request ​https://github.com/adblockplus/libadblockplus/pull/2

comment:3 Changed on 05/30/2015 at 10:58:00 AM by Mailkov

Can you assign it to me? So I will receive e-mail on this issue.

comment:4 Changed on 06/03/2015 at 11:51:11 AM by fhd

  • Owner set to Mailkov

comment:5 Changed on 06/03/2015 at 11:53:43 AM by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed on 06/19/2015 at 07:16:16 PM by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed

Pushed: ​https://hg.adblockplus.org/libadblockplus/rev/fb7b44c3baa9

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Mailkov.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.