Context Navigation

Opened on 08/29/2014 at 01:08:49 PM

Closed on 09/17/2014 at 02:35:34 PM

#1286 closed change (fixed)

Reported by:	fhd	Assignee:	hexene
Priority:	P4	Milestone:
Module:	Libadblockplus	Keywords:
Cc:	trev	Blocked By:
Blocking:		Platform:	Unknown
Ready:	yes	Confidential:	no
Tester:		Verified working:	no
Review URL(s):	https://github.com/adblockplus/libadblockplus/pull/1

FilterEngine::Matches currently gets contentType as a string. Since there's a fixed list of supported content types, it should rather be an enum.

Create a ContentType enum and use it in FilterEngine::Matches.

You may use WikiFormatting here.

Change Properties

Summary:
Description:	You may use WikiFormatting here. === Background === ''FilterEngine::Matches'' currently gets ''contentType'' as a string. Since there's a fixed list of supported content types, it should rather be an enum. === What to change === Create a ''ContentType'' enum and use it in ''FilterEngine::Matches''.
Type:		Priority:
Milestone:		Module:
Keywords:		Cc:
Blocked By:		Blocking:
Platform:		Ready:
Confidential:		Tester:
Verified working:
Review URL(s):	https://github.com/adblockplus/libadblockplus/pull/1

Action

leave as closed .

reopen The resolution will be deleted. Next status will be 'reopened'.

reassign to The owner will be changed from hexene.

Attachments ↑ Description ↑

Note: See TracTickets for help on using tickets.