Opened on 08/29/2014 at 08:20:21 PM
Closed on 08/31/2014 at 04:12:43 PM
Last modified on 09/08/2014 at 11:30:51 AM
#1290 closed defect (fixed)
Stylesheets aren't injected with Shadow DOM anymore
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-1.8.5-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Chrome | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description (last modified by sebastian)
Environment
Chrome 37
How to reproduce
- Visit any website
- Inspect the page (Ctrl + Shift + I)
Observed behaviour
You see the stylesheet Adblock Plus injected into the light DOM, bringing back issues like #309 and #369.
That is because since Chrome 36 there is no webkitCreateShadowRoot anymore. However, the un-prefixed createShadowRoot (added in Chrome 35) isn't supported by Adblock Plus yet.
Expected behaviour
The stylesheet should be injected with the Shadow DOM, hiding it from the website's JavaScript.
Attachments (0)
Change History (4)
comment:1 Changed on 08/29/2014 at 08:25:16 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 08/31/2014 at 04:12:43 PM by sebastian
- Description modified (diff)
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:3 Changed on 09/01/2014 at 08:44:14 AM by sebastian
- Summary changed from Stylesheets aren't injected with Shadow DOM anymore on Chrome 37 to Stylesheets aren't injected with Shadow DOM anymore
comment:4 Changed on 09/08/2014 at 11:30:51 AM by trev
- Milestone changed from Adblock-Plus-for-Chrome-Opera-Safari-1.8.4 to Adblock-Plus-for-Chrome-Opera-Safari-next
Note: See
TracTickets for help on using
tickets.
https://hg.adblockplus.org/adblockpluschrome/rev/6c4216f6ae02