Opened on 09/01/2014 at 10:48:07 AM
Closed on 12/07/2015 at 04:24:00 PM
#1292 closed defect (fixed)
Adapt style of donate and share sections on first-run page for smaller screens
| Reported by: | passbrains | Assignee: | greiner |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | User-Interface | Keywords: | goodfirstbug |
| Cc: | manvel@adblockplus.org | Blocked By: | |
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by greiner)
Adapted from https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=AFI-14
Environment
Sony Ericsson Xperia T Android 4.3 Jelly Bean
ABP version 2.6.4.3852
How to reproduce
Firefox 31.0
- Install Firefox Mobile Plugin
- An ABP successfully installed page will be displayed
- Check the two dotted lines near the donate and share section
Another way of reproduction could be:
- Open first run page of ABP from Firefox for Desktop "chrome://adblockplus/content/ui/firstRun.html"
- resize the browser window so the "Tell your friends" section will get under "Support our project"
Observed behaviour
Left border is missing the lower half, right one is broken
Expected behaviour
Instead of the vertical borders there should be a horizontal border with the same style between the two sections.
What to change
On smaller screens i.e. width < 970px (760px maximum width + 2 * 100px padding + 10px extra)
- hide the vertical borders of the donate and share section
- make the two sections display: block to ensure that they're aligned vertically
- add bottom border with the same styles as the vertical ones to donate section and include 20px space between section and border
Attachments (1)
Change History (13)
Changed on 09/01/2014 at 10:48:09 AM by passbrains
comment:1 Changed on 09/01/2014 at 11:00:00 AM by saroyanm
- Component changed from Unknown to Adblock-Plus-for-Firefox
- Description modified (diff)
- Summary changed from ABP successfully installed page dotted lines are missing and broken to ABP First run page dotted lines are missing and broken
comment:2 Changed on 09/01/2014 at 11:09:37 AM by saroyanm
- Ready set
comment:3 Changed on 09/01/2014 at 01:23:30 PM by saroyanm
- Cc manvel@adblockplus.org added
comment:4 Changed on 09/16/2014 at 10:36:59 AM by greiner
- Component changed from Adblock-Plus-for-Firefox to User-Interface
- Priority changed from Unknown to P3
- Summary changed from ABP First run page dotted lines are missing and broken to Vertical lines on first-run page are oddly positioned on smaller screens
comment:6 Changed on 02/19/2015 at 05:52:02 PM by greiner
- Keywords goodfirstbug added
- Summary changed from Vertical lines on first-run page are oddly positioned on smaller screens to Adapt style of donate and share sections on first-run page for smaller screens
comment:7 Changed on 02/19/2015 at 06:14:21 PM by greiner
- Blocking 2018 added
comment:8 Changed on 05/20/2015 at 02:22:39 PM by philll
- Platform changed from Firefox/Firefox Mobile to Firefox
Made Firefox and Firefox mobile available as seperate platforms.
comment:9 Changed on 09/30/2015 at 03:36:48 PM by greiner
- Blocking 2018 removed
comment:10 Changed on 10/12/2015 at 11:43:24 AM by greiner
- Owner set to greiner
- Tester set to Unknown
comment:11 Changed on 10/12/2015 at 01:40:49 PM by greiner
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:12 Changed on 12/07/2015 at 04:24:00 PM by greiner
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
One solution to this would be to hide the vertical lines on small enough screens and instead show a horizontal line between the donate and the share block.