Opened on 09/02/2014 at 05:18:08 AM

Closed on 06/19/2015 at 07:46:32 PM

#1297 closed change (fixed)

Prefix internal events with "_"

Reported by: fhd Assignee: Mailkov
Priority: P4 Milestone:
Module: Libadblockplus Keywords:
Cc: trev Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​https://github.com/adblockplus/libadblockplus/pull/3

Description

Background

FilterEngine currently throws two events that are only used internally: "init" and "updateCheckDone". Since there can be only one callback for each event, we should make it more obvious that clients shouldn't interfere with those events. Prefixing by "_" seems like it would make this more obvious.

What to change

Prefix the "init" and "updateCheckDone" events with a "_".

Attachments (0)

Change History (7)

comment:1 Changed on 09/02/2014 at 01:10:26 PM by trev

  • Cc trev added

comment:2 Changed on 05/20/2015 at 12:32:32 PM by Mailkov

Hi, I would like to work on this !!!

comment:3 Changed on 05/20/2015 at 12:35:11 PM by Mailkov

pull request ​https://github.com/adblockplus/libadblockplus/pull/3

comment:4 Changed on 05/30/2015 at 10:59:01 AM by Mailkov

Can you assign it to me? So I will receive e-mail on this issue.

comment:5 Changed on 06/03/2015 at 11:50:49 AM by fhd

  • Owner set to Mailkov

comment:6 Changed on 06/03/2015 at 11:53:34 AM by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed on 06/19/2015 at 07:46:32 PM by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed

Pushed: ​https://hg.adblockplus.org/libadblockplus/rev/8aca4f464e7f

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Mailkov.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.