Opened on 09/02/2014 at 09:36:41 PM
Closed on 11/10/2017 at 11:15:18 AM
#1301 closed change (rejected)
Don't fake window.content property in the Blockable items frame
| Reported by: | trev | Assignee: | |
|---|---|---|---|
| Priority: | P4 | Milestone: | |
| Module: | Adblock-Plus-for-Firefox | Keywords: | goodfirstbug |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Background
The list of blockable items runs inside a frame in the browser window. For historical reasons, we define a window.content property inside this frame that points to the window object of the current browser tab - this frame started out as a sidebar, and Firefox sidebars have that functionality. This is somewhat ugly though https://bugzilla.mozilla.org/show_bug.cgi?id=930787#c15 is the first issue this approach ever caused.
What to change
Implement this functionality in a more obvious way, e.g. as a getCurrentContentWindow() function - this way it is obviously a dynamically determined value rather than a constant.
Attachments (0)
Change History (2)
comment:1 Changed on 05/20/2015 at 02:22:39 PM by philll
- Platform changed from Firefox/Firefox Mobile to Firefox
comment:2 Changed on 11/10/2017 at 11:15:18 AM by trev
- Resolution set to rejected
- Status changed from new to closed
Mass-closing all bugs in Adblock Plus for Firefox module, the codebase of Adblock Plus 3.0 belongs into Platform and User-Interface modules. Old bugs are unlikely to still apply.
Made Firefox and Firefox mobile available as seperate platforms.