Opened on 09/15/2014 at 11:37:06 AM

Closed on 08/13/2015 at 05:26:28 PM

#1376 closed change (fixed)

Write tests for FilterEngine::SetFilterChangeCallback

Reported by: fhd Assignee: fhd
Priority: P3 Milestone:
Module: Libadblockplus Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/4756164013195264/

Description

Background

We have pretty good test coverage in libadblockplus, but no tests where added when FilterEngine::SetFilterChangeCallback was introduced in 803eef18bfe7.

What to change

Write a test for FilterEngine::SetFilterChangeCallback.

Attachments (0)

Change History (4)

comment:1 Changed on 09/16/2014 at 09:37:35 AM by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 03/13/2015 at 05:13:42 PM by trev

  • Owner set to fhd

comment:4 Changed on 08/13/2015 at 05:26:28 PM by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from fhd.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.