Opened on 03/13/2014 at 01:12:48 PM
Closed on 09/15/2014 at 11:01:18 AM
Last modified on 05/20/2015 at 02:22:39 PM
#139 closed change (fixed)
[Remove timeline code] Remove timeline.js and callers
| Reported by: | trev | Assignee: | beelzy |
|---|---|---|---|
| Priority: | P4 | Milestone: | Adblock-Plus-2.6.5-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | goodfirstbug |
| Cc: | Blocked By: | ||
| Blocking: | #138 | Platform: | Firefox |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Attachments (1)
Change History (10)
comment:1 Changed on 04/24/2014 at 12:22:42 PM by trev
- Keywords goodfirstbug added
- Ready unset
comment:2 Changed on 05/09/2014 at 03:19:28 PM by philll
comment:3 Changed on 05/09/2014 at 04:13:20 PM by trev
- Ready set
Sure, it can be worked on - that issue was simply filed before the ready flag was added, so any (unrelated) change would "unset" it.
comment:4 Changed on 05/19/2014 at 10:46:46 AM by beelzy
Hi, can I work on this bug? I've already removed the lines that use Timeline and got rid of timeline.js. Tests work fine except for certain unit tests that weren't already working (I saw there was an issue for that). Just need to create a patch for it.
comment:5 Changed on 05/20/2014 at 11:47:43 AM by trev
- Owner set to beelzy
I assigned that issue to you. Please see https://adblockplus.org/en/contribute-code for some general instructions. Once you are done you can create a GitHub pull request or attach the patch here.
Changed on 05/20/2014 at 12:31:05 PM by beelzy
Apply to commit 972408582c2390594f1bda74b1d8fdde2f4e215b (should be the latest one at time of writing)
comment:6 Changed on 05/20/2014 at 12:31:38 PM by beelzy
Attached the patch. Where do I send the contributor agreement to? I could possibly also do #140 as well, since it appears to be closely related.
comment:7 Changed on 06/11/2014 at 08:46:33 AM by trev
Sorry about the late reply, I somehow forgot replying here. The contributor agreement should go to me (trev@adblockplus.org).
comment:8 Changed on 09/15/2014 at 11:01:18 AM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Platform set to Firefox/Firefox Mobile
- Resolution set to fixed
- Status changed from new to closed
Heh, this one dropped off my radar again :-(
Anyway, fixed:
https://hg.adblockplus.org/adblockplus/rev/47be8c5680f7
https://hg.adblockplus.org/adblockplus/rev/7313f49c65e3
The original patch has been rebased. The second patch actually makes sure that the removed timelineID parameter isn't being passed in by the caller.
comment:9 Changed on 05/20/2015 at 02:22:39 PM by philll
- Platform changed from Firefox/Firefox Mobile to Firefox
Made Firefox and Firefox mobile available as seperate platforms.
You marked this as goodfirstbug but at the same time removed the ready flag. Shall this be worked on or not?