Opened on 09/26/2014 at 01:38:03 PM

#1450 new change

Show msg_update_missing for manual update checks

Reported by: fhd Assignee:
Priority: P3 Milestone:
Module: Adblock-Plus-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Android
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

Description

Background

We have currently no way of telling whether an update was available in AndroidUpdateCheckDoneCallback, so we can't show msg_update_missing in this case.

What to change

I can think of two options:

  1. We do something Android specific, e.g. some shared state between AndroidUpdateAvailableCallback and AndroidUpdateCheckDoneCallback- they are always invoked in that order.
  2. We pass this information to UpdateCheckDoneCallback in libadblockplus.

The second approach seems cleaner.

Attachments (0)

Change History (0)

Add Comment

Modify Ticket

Change Properties
Action
as new .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from (none).
Next status will be 'reviewing'.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.