Opened on 10/01/2014 at 11:16:46 AM

Closed on 10/01/2014 at 12:08:47 PM

#1457 closed change (fixed)

Remove update check menu entry

Reported by: fhd Assignee: fhd
Priority: P3 Milestone: Adblock-Plus-for-Android-1.3
Module: Adblock-Plus-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Android
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/4758885344739328/

Description

Background

#98 added an update check menu entry to the main activity, but there's already an update check item in advanced preferences that works just fine.

What to change

Remove the update check menu entry on the Preferences activity.

Attachments (0)

Change History (6)

comment:1 Changed on 10/01/2014 at 11:17:28 AM by fhd

  • Owner set to fhd

comment:2 Changed on 10/01/2014 at 11:18:38 AM by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 10/01/2014 at 11:41:12 AM by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed

Pushed: ​https://hg.adblockplus.org/adblockplusandroid/rev/0e606304d8a7

comment:4 Changed on 10/01/2014 at 11:43:48 AM by fhd

  • Milestone set to Adblock-Plus-for-Android-1.3

comment:5 Changed on 10/01/2014 at 11:59:00 AM by fhd

  • Resolution fixed deleted
  • Status changed from closed to reopened

Crap, removed the wrong string :( Updating the review...

comment:6 Changed on 10/01/2014 at 12:08:47 PM by fhd

  • Resolution set to fixed
  • Status changed from reopened to closed

Pushed the fix: ​https://hg.adblockplus.org/adblockplusandroid/rev/20dba756a42a

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from fhd.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.