Opened on 10/08/2014 at 03:00:25 PM
Closed on 02/05/2015 at 10:35:50 AM
Last modified on 02/25/2015 at 06:45:58 PM
#1466 closed change (fixed)
fix usage of BSTR
Reported by: | sergz | Assignee: | sergz |
---|---|---|---|
Priority: | P3 | Milestone: | Adblock-Plus-for-Internet-Explorer-1.4 |
Module: | Adblock-Plus-for-Internet-Explorer | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Platform: | Internet Explorer | |
Ready: | yes | Confidential: | no |
Tester: | Verified working: | no | |
Review URL(s): |
http://codereview.adblockplus.org/5698769010032640/ |
Description
Background
We pass wchar_t* strings to methods which expect BSTR. The problem is that BSTR has a different layout, it has length prefix which is apparently missed in wchar_t*. So we are lucky that nobody calls SysStringLen to obtain the string length.
What to change
Pass BSTR.
Attachments (0)
Change History (5)
comment:1 Changed on 01/30/2015 at 10:19:12 AM by sergz
- Status changed from new to reviewing
comment:2 Changed on 02/05/2015 at 10:35:50 AM by sergz
- Resolution set to fixed
- Status changed from reviewing to closed
comment:3 Changed on 02/19/2015 at 07:44:17 AM by oleksandr
- Milestone set to Adblock-Plus-for-Internet-Explorer-1.4
- Platform changed from Unknown to Internet Explorer
- Priority changed from Unknown to P3
comment:4 Changed on 02/25/2015 at 06:28:32 PM by oleksandr
- This was pushed with line endings change: https://hg.adblockplus.org/adblockplusie/rev/6fd3d5ce341e
- There was a typo on line 280 in PluginDomTraverserBase.h. src != scr, which causes some element hiding filter to not work.
Note: See
TracTickets for help on using
tickets.