Opened on 10/20/2014 at 07:42:57 AM
Last modified on 12/22/2016 at 03:18:07 AM
#1484 reviewing change
Go back to using the third-party version PassthroughApp
| Reported by: | sergz | Assignee: | |
|---|---|---|---|
| Priority: | P4 | Milestone: | Adblock-Plus-for-Internet-Explorer-Next |
| Module: | Adblock-Plus-for-Internet-Explorer | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Internet Explorer | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://codereview.adblockplus.org/29331579/ |
||
Description (last modified by eric@adblockplus.org)
Background
Eric says (source):
by modifying the SinkPolicy.* files we can no longer directly import future updates to PassthroughAPP.
What to change
Eric says (source):
Given that the code that was modified in those files was templated, it seems we could keep compatibility with the external code by using a template specialization rather than modify the external code itself.
Using template specialization is one possible method of accomplishing the larger goal, which is to use PassthroughAPP as distributed.
Attachments (0)
Change History (7)
comment:1 Changed on 10/20/2014 at 08:54:14 AM by fhd
- Blocking 1486 added
comment:2 Changed on 10/26/2014 at 05:30:49 PM by oleksandr
- Priority changed from Unknown to P4
- Ready set
comment:3 Changed on 12/02/2015 at 02:18:19 PM by eric@adblockplus.org
comment:4 Changed on 12/23/2015 at 03:40:46 PM by eric@adblockplus.org
- Review URL(s) modified (diff)
comment:5 Changed on 11/21/2016 at 10:47:39 AM by oleksandr
- Milestone set to Adblock-Plus-for-Internet-Explorer-Next
comment:6 Changed on 11/21/2016 at 11:13:29 AM by oleksandr
- Blocking 1486 removed
comment:7 Changed on 12/22/2016 at 03:18:07 AM by oleksandr
- Milestone changed from Adblock-Plus-for-Internet-Explorer-1.6 to Adblock-Plus-for-Internet-Explorer-Next
Note: See
TracTickets for help on using
tickets.
