Opened on 10/23/2014 at 08:21:54 AM
Closed on 12/15/2014 at 09:15:08 AM
#1495 closed change (fixed)
Allow Puppet sitescripts and ::configfragment to be used with templates
| Reported by: | matze | Assignee: | matze |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Unknown | Keywords: | sitescripts |
| Cc: | trev, fhd, AAlvz, poz2k4444 | Blocked By: | |
| Blocking: | #240 | Platform: | Unknown |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): |
http://codereview.adblockplus.org/6122106488094720/ |
||
Description
Background
Currently, both class {'sitescripts': } and sitescripts::configfragment() only allow for source locations being specified (using the $sitescriptsini_source parameter). This cannot be used in connection with e.g. the Puppet template() function, which prevents easy creation and customization of sitescripts.ini files.
What to change
Incorporate a $sitescriptsini_content parameter that can be used instead of $sitescriptsini_source in both the sitescripts class and the sitescripts::configfragment type.
Attachments (0)
Change History (5)
comment:3 Changed on 11/26/2014 at 02:16:07 PM by matze
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 11/26/2014 at 11:37:57 PM by matze
- Priority changed from Unknown to P2
- Ready set
comment:5 Changed on 12/15/2014 at 09:15:08 AM by matze
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
(Applied same priority as in ticket #240, since these changes are to be included in there.)