Opened on 11/04/2014 at 03:44:05 PM
Closed on 11/10/2014 at 02:25:28 PM
#1522 closed change (fixed)
Use classList attribute when generating element hiding filters
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P4 | Milestone: | Adblock-Plus-1.8.8-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | goodfirstbug |
| Cc: | greiner | Blocked By: | |
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Background
The code that generates element hiding filters based on the class attribute, when using "Block element" functionality, is splitting the value of the className property to retrieve a list of classes. However, since Chrome 8 and Safari 5.1 we can use the classList attribute, which already provides a list of classes, instead rolling our own logic to split classes.
What to change
Use classList attribute instead splitting className to retrieve a list of classes.
Attachments (0)
Change History (3)
comment:1 Changed on 11/04/2014 at 03:52:19 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
- Summary changed from Make classList attribute when generating element hiding filters to Use classList attribute when generating element hiding filters
comment:2 Changed on 11/04/2014 at 03:52:30 PM by sebastian
- Owner set to sebastian
comment:3 Changed on 11/10/2014 at 02:25:28 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
https://hg.adblockplus.org/adblockpluschrome/rev/3d5fe3fc704c