Opened on 11/06/2014 at 11:17:08 AM
Closed on 02/25/2015 at 07:23:35 PM
Last modified on 05/20/2015 at 02:22:39 PM
#1534 closed change (fixed)
Replace ABP icon with new one - for Firefox
| Reported by: | sven | Assignee: | trev |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-2.6.8-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | trev, greiner | Blocked By: | |
| Blocking: | #1533 | Platform: | Firefox |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description (last modified by trev)
Background
We've created a new icon that was announced and discussed in our blog and in our forum. After some improvements, these icons are ready to implement now.
What to change
Replace the current ABP icons with the new ones (consider: all images are overly large, they should go through pngout first.):
| Repo | Filename | Size(px) | UseCase | NewFile |
| adblockplus | icon.png | 48x48 | about:addons | 48px-active_v1_2.png |
| adblockplus | icon64.png | 64x64 | about:addons | 64px-active_v1_2.png |
| adblockplus | chrome/skin/abp-status.png | 24x48 | Toolbar icon (default + inactive) | 24px-active_inactive_v1_2.png |
| adblockplus | chrome/skin/abp-status-16.png | 16x32 | Toolbar icon (default + inactive) | 16px-active_inactive_v1_2.png |
| adblockplus | chrome/skin/abp-status-32.png | 32x64 | Toolbar icon (default + inactive) | 32px-active_inactive_v1_2.png |
Attachments (5)
Change History (31)
comment:2 Changed on 11/06/2014 at 11:41:15 AM by sven
- Blocking 1533 added
comment:3 Changed on 11/11/2014 at 08:50:40 AM by fhd
- Component changed from User-Interface to Adblock-Plus-for-Firefox
- Platform changed from Unknown to Firefox/Firefox Mobile
comment:4 Changed on 11/11/2014 at 08:53:59 AM by fhd
- Priority changed from P2 to P3
comment:5 Changed on 12/04/2014 at 10:52:22 AM by fhd
comment:6 Changed on 01/23/2015 at 03:31:55 PM by sven
- Description modified (diff)
- Summary changed from Replace ABP icon with new one (v.1.0) - for Firefox to Replace ABP icon with new one (v.1.1) - for Firefox
comment:7 Changed on 01/23/2015 at 03:40:28 PM by sven
We improved the 16px and the 19px version (v1.1). It's ready to implement now.
comment:8 Changed on 02/09/2015 at 11:09:34 AM by trev
- Cc trev added
Sven, we also need 48x48 and 64x64 for Firefox ("enabled" only).
comment:9 Changed on 02/09/2015 at 04:49:21 PM by sven
We will upload it this Wednesday at the latest
comment:10 Changed on 02/10/2015 at 07:13:38 AM by christiane
both files attached.
comment:11 Changed on 02/10/2015 at 11:00:07 AM by philll
- Resolution set to invalid
- Status changed from new to closed
Please provide a proper Issue description. There are four attachments and way more image files in those. It is unlikely that a developer will guess correctly which of those should be used where and replace what.
comment:12 Changed on 02/10/2015 at 06:28:33 PM by trev
- Description modified (diff)
After looking through the archives, I noticed that 24x24 icons are missing as well.
comment:13 Changed on 02/11/2015 at 10:26:45 AM by sven
The 48px and 64px icon will need improvements since they aren't used for toolbar icons. This was not clear after @trev's comment: "we also need 48x48 and 64x64 for Firefox ("enabled" only)". We work on that.
comment:14 Changed on 02/11/2015 at 10:29:06 AM by sven
- Description modified (diff)
comment:15 Changed on 02/11/2015 at 10:42:31 AM by sven
- Description modified (diff)
comment:16 follow-up: ↓ 17 Changed on 02/11/2015 at 10:44:27 AM by sven
The "48px-active_v1_1.png" and "64px-active_v1_1.png" icons should be removed from the attachements since they are not up to date anymore and could cause confusions.
comment:17 in reply to: ↑ 16 Changed on 02/11/2015 at 06:56:03 PM by greiner
- Cc greiner added
Please only upload those images which are relevant for an issue - if necessary already in the form of a sprite so that they can be added without modifying the images themselves to ensure that images are added exactly as they were provided. You can find all relevant images for this issue in the adblockplus repository (can be downloaded by clicking on "zip" link).
Finally, I noticed that none of the issues currently listed under #1533 are about replacing the icon on the first-run page due to it being part of the adblockplusui repository.
Replying to sven:
The "48px-active_v1_1.png" and "64px-active_v1_1.png" icons should be removed from the attachements since they are not up to date anymore and could cause confusions.
This is not necessary since only the relevant attachments should be linked to in the issue description and therefore considered.
comment:18 Changed on 02/16/2015 at 09:02:05 AM by sven
This is not necessary since only the relevant attachments should be linked to in the issue description and therefore considered.
Agree.
Changed on 02/17/2015 at 01:55:57 PM by sven
Changed on 02/17/2015 at 01:56:03 PM by sven
Changed on 02/17/2015 at 02:18:47 PM by sven
Changed on 02/17/2015 at 02:18:57 PM by sven
Changed on 02/17/2015 at 02:19:08 PM by sven
comment:19 Changed on 02/17/2015 at 02:23:53 PM by sven
- Description modified (diff)
- Resolution invalid deleted
- Status changed from closed to reopened
comment:20 Changed on 02/18/2015 at 06:17:48 PM by trev
- Description modified (diff)
- Ready set
comment:21 Changed on 02/18/2015 at 06:25:09 PM by trev
- Summary changed from Replace ABP icon with new one (v.1.1) - for Firefox to Replace ABP icon with new one - for Firefox
comment:22 Changed on 02/25/2015 at 05:19:22 PM by trev
- Owner set to trev
comment:23 Changed on 02/25/2015 at 05:19:33 PM by trev
- Review URL(s) modified (diff)
- Status changed from reopened to reviewing
comment:24 Changed on 02/25/2015 at 07:23:35 PM by trev
- Resolution set to fixed
- Status changed from reviewing to closed
comment:25 Changed on 02/25/2015 at 07:51:31 PM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
comment:26 Changed on 05/20/2015 at 02:22:39 PM by philll
- Platform changed from Firefox/Firefox Mobile to Firefox
Made Firefox and Firefox mobile available as seperate platforms.
Unsetting ready for now - Sven would still like to go over this with the new designer in January.