Opened on 11/07/2014 at 01:00:07 PM

Closed on 02/10/2015 at 11:31:14 AM

#1547 closed change (fixed)

Pass isolate to v8::API

Reported by: sergz Assignee:
Priority: Unknown Milestone:
Module: Libadblockplus Keywords:
Cc: Blocked By:
Blocking: #1197 Platform: Unknown
Ready: no Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/6112412478472192/

Description

Background

Recent v8 api required to pass isolate in most functions. For example, it does not support constructing of v8::String without specifying isolate anymore ​https://code.google.com/p/v8/source/browse/trunk/include/v8.h?r=25122#2012 .

The tendency seems to get rid of v8::Isolate::GetCurrent(), so it looks better for future to avoid such calls.

What to change

Add v8::Isolate* argument and adapt all calls of AdblockPlus::Utils::ToV8String and to other calls.

Attachments (0)

Change History (2)

comment:1 Changed on 11/10/2014 at 09:43:16 AM by sergz

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 02/10/2015 at 11:31:14 AM by sergz

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.