Opened on 11/07/2014 at 12:59:36 PM
Closed on 07/04/2017 at 02:40:10 PM
#1546 closed change (fixed)
Change the signature of native callback functions
Reported by: | sergz | Assignee: | |
---|---|---|---|
Priority: | Unknown | Milestone: | |
Module: | Libadblockplus | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | #1197 | Platform: | Unknown |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description
Background
The recent signature is void FunctionCallback(const FunctionCallbackInfo<Value>& info); thus no return value and instead of v8::Arguments v8::FunctionCallbackInfo.
- To return value one has to use info.GetReturnValue().Set(value to return);.
- To throw an exception one has to call isolate->ThrowException(value).
- To return v8::Undefined - do nothing.
Attachments (0)
Change History (1)
comment:1 Changed on 07/04/2017 at 02:40:10 PM by sergz
- Resolution set to fixed
- Status changed from new to closed
- Tester set to Unknown
Note: See
TracTickets for help on using
tickets.
Done as a part of #4907.