Opened on 11/07/2014 at 01:15:14 PM
Closed on 11/19/2014 at 11:59:09 AM
#1549 closed change (fixed)
Initialize v8::V8
| Reported by: | sergz | Assignee: | |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Libadblockplus | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #1197 | Platform: | Unknown |
| Ready: | no | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description (last modified by sergz)
Background
The recent v8 does not automatically initialize thread local storage required by v8::Isolate.
If v8::V8 is not initialized then thread_data_table_ is nullptr, the callstack is
> tests.exe!v8::internal::Isolate::Isolate(bool enable_serializer) Line 1515 C++ tests.exe!v8::Isolate::New(const v8::Isolate::CreateParams & params) Line 6594 C++ tests.exe!AdblockPlus::IsolateManagerJsEngine::IsolateManagerJsEngine() Line 62 C++ tests.exe!AdblockPlus::IsolateScopeJsEngine::IsolateScopeJsEngine() Line 76 C++ tests.exe!AdblockPlus::ContextScopeJsEngine::ContextScopeJsEngine() C++ tests.exe!AdblockPlus::JsEngine::JsEngine(AdblockPlus::JsEngine::PrivateCtrArg __formal) Line 74 C++ tests.exe!std::_Ref_count_obj<AdblockPlus::JsEngine>::_Ref_count_obj<AdblockPlus::JsEngine><AdblockPlus::JsEngine::PrivateCtrArg>(AdblockPlus::JsEngine::PrivateCtrArg && <_Args_0>) Line 932 C++ tests.exe!std::make_shared<AdblockPlus::JsEngine,AdblockPlus::JsEngine::PrivateCtrArg>(AdblockPlus::JsEngine::PrivateCtrArg && <_Args_0>) Line 1003 C++ tests.exe!AdblockPlus::JsEngine::New(const AdblockPlus::AppInfo & appInfo) Line 80 C++ ....
Attachments (0)
Change History (3)
comment:1 Changed on 11/10/2014 at 09:40:20 AM by sergz
- Description modified (diff)
- Summary changed from Create v8::Platform and initialize v8::V8 to Initialize v8::V8
comment:2 Changed on 11/10/2014 at 09:44:22 AM by sergz
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 11/19/2014 at 11:59:09 AM by sergz
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
