Opened on 11/07/2014 at 01:37:48 PM

Closed on 11/19/2014 at 11:59:56 AM

#1551 closed change (fixed)

Move global callbackParams and stuff around it into the scope of particular test

Reported by: sergz Assignee:
Priority: Unknown Milestone:
Module: Libadblockplus Keywords:
Cc: Blocked By:
Blocking: #1197 Platform: Unknown
Ready: no Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/5139568831496192/

Description

Background

The file is test/JsEngine.cpp.
In the recent v8 the order of destroying of isolate is very important. Global callbackParams holds the pointer to isolate and accesses it in the destructor. At this moment the isolate is already destroyed and the application crashes.

Attachments (0)

Change History (2)

comment:1 Changed on 11/10/2014 at 09:46:12 AM by sergz

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 11/19/2014 at 11:59:56 AM by sergz

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.