Opened on 11/15/2014 at 11:57:35 PM

Closed on 11/17/2014 at 04:22:39 PM

#1571 closed defect (fixed)

Unit tests reference non-existing timeline.js file

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: Extensions-for-Adblock-Plus Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/6021260119113728

Description

Background

timeline.js has recently been removed from Adblock Plus. Yet the unit tests still try to access it in order to disable this functionality. This produces an error message in console.

What to change

Get rid of the code accessing timeline.js.

Attachments (0)

Change History (2)

comment:1 Changed on 11/16/2014 at 12:00:55 AM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 11/17/2014 at 04:22:39 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed:

​https://hg.adblockplus.org/adblockplustests/rev/98723b040ad2

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.