Opened on 11/19/2014 at 09:23:13 PM

Last modified on 06/30/2015 at 03:11:18 PM

#1586 reviewing change

Fix doxygen comment for documentUrls in FilterEngine::Matches

Reported by: fhd Assignee: Mailkov
Priority: P3 Milestone:
Module: Libadblockplus Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://github.com/adblockplus/libadblockplus/pull/4

Description

Background

​The comment for FilterEngine::Matches currently says the following about documentUrls: "Chain of documents requesting the resource, starting with the current resource's parent frame, ending with the top-level frame.". That's the wrong way around.

What to change

The comment should say: "Chain of documents requesting the resource, starting with the top-level frame, ending with the current resource's parent frame.

Attachments (0)

Change History (4)

comment:1 Changed on 06/20/2015 at 07:13:04 AM by Mailkov

I'd like to work on this!

comment:2 Changed on 06/20/2015 at 07:16:15 AM by Mailkov

Pull request: ​https://github.com/adblockplus/libadblockplus/pull/4

comment:3 Changed on 06/30/2015 at 03:10:55 PM by fhd

  • Owner set to Mailkov
  • Tester set to Unknown

comment:4 Changed on 06/30/2015 at 03:11:18 PM by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

Add Comment

Modify Ticket

Change Properties
Action
as reviewing .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Mailkov.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.