Opened on 11/21/2014 at 04:25:32 PM
Closed on 11/25/2014 at 04:34:50 PM
Last modified on 11/27/2014 at 02:11:44 PM
#1592 closed defect (fixed)
Blocked frames aren't collapsed on Safari
| Reported by: | scump | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-1.8.8-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | mapx | Blocked By: | |
| Blocking: | Platform: | Safari | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Environment
OS X 10.10, Safari 8.0, ABP dev build 1.8.7.1256, EasyList, EasyPrivacy, Fanboy's Annoyance List.
How to reproduce
- Go to http://thepiratebay.se
- Search anything
- When the results appears, the ads are properly blocked, but the placeholders of the blocked elements aren't hidden.
Observed behaviour
The problem occurs only with Safari. No problem with Chrome and Firefox.
Attachments (0)
Change History (5)
comment:1 Changed on 11/21/2014 at 04:28:19 PM by mapx
- Cc sebastian mapx added
comment:2 Changed on 11/22/2014 at 12:44:36 PM by sebastian
- Component changed from Unknown to Platform
- Owner set to sebastian
- Priority changed from Unknown to P2
- Ready set
comment:3 Changed on 11/22/2014 at 02:03:54 PM by sebastian
- Cc sebastian removed
- Review URL(s) modified (diff)
- Status changed from new to reviewing
Last edited on 11/25/2014 at 01:26:47 PM
by sebastian
comment:4 Changed on 11/25/2014 at 04:34:50 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 11/27/2014 at 02:11:44 PM by sebastian
- Summary changed from Placeholders of blocked elements not hidden on thepiratebay.se with Safari to Blocked frames aren't collapsed on Safari
Note: See
TracTickets for help on using
tickets.
No load event is dispatched for blocked frames, and therefore element collapsing does not work.
We stopped manually dispatching load events for blocked frames a while ago. The review documents that this isn't necessary, since Safari automatically dispatches those events for blocked frames. However, I just tested it on Safari 8 an 5.1, and with both versions of Safari no load event is dispatched.