Opened on 11/24/2014 at 03:21:12 PM

Closed on 12/09/2014 at 11:53:11 AM

#1601 closed defect (fixed)

"Block element" does not generate blocking filters for elements with multiple URLs

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.8.9-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5468762555809792

Description

How to reproduce

  1. Go to http://www.webkit.org/demos/srcset/ or http://www.w3schools.com/html/html5_video.asp
  2. Click the ABP icon
  3. Choose "Block element"
  4. Click the sample image or video respectively

Observed behaviour

The dialog shows up, but it neither generates blocking filters for the video's URLs (configured with <source> child elements), nor for the alternative sizes (configured by the srcset attribute) of the image.

Expected behaviour

Blocking filters for all URLs associated with selected element should be generated.

Attachments (0)

Change History (2)

comment:1 Changed on 11/24/2014 at 03:22:34 PM by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 12/09/2014 at 11:53:11 AM by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sebastian.
 
Note: See TracTickets for help on using tickets.