Opened on 11/25/2014 at 06:18:16 PM
Closed on 08/26/2019 at 12:00:27 PM
#1608 closed change (incomplete)
Introduce SCM module in Puppet
Reported by: | matze | Assignee: | matze |
---|---|---|---|
Priority: | P2 | Milestone: | |
Module: | Infrastructure | Keywords: | |
Cc: | fhd, fred | Blocked By: | |
Blocking: | #3663 | Platform: | Unknown |
Ready: | yes | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description
(As discussed with @trev and @fhd on IRC:) We have a few dozen exec {... } based invocations of hg(1) in our infrastructure repository, and almost as many different versions when looking at the details. This should become abstracted in order to not repeat ourselves and to remove unnecessary possible failure sources.
Goal
Introduce a Puppet module that abstracts the invocations and replace the aforementioned exec {... } directives accordingly.
Notes
There's probably plenty of similar modules out there already, so we may not need to write a new one from scratch. Still, since it's a relatively trivial domain, we may not want to introduce another explicit dependency for this. Especially since we may want to also integrate the ensure_dependency.py script based on this module, and thus may need to apply more patches to any existing module than an individual solution would require.
Attachments (0)
Change History (10)
comment:1 Changed on 11/25/2014 at 06:20:41 PM by matze
comment:2 Changed on 01/05/2015 at 03:15:00 PM by matze
- Owner changed from AAlvz, poz2k4444 to matze
comment:3 Changed on 01/05/2015 at 03:15:10 PM by matze
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 02/22/2016 at 02:43:48 PM by matze
- Cc fred added; trev removed
- Priority changed from P4 to P2
- Review URL(s) modified (diff)
- Tester set to Unknown
With our recent plans to use bookmarks as feature branches, i.e. master, we have to address most of the code snippets in question for this ticket here anyway. Hence I do consider the implementation more urgent now, and also include the requirement for post-update trigger support (i.e. python ensure_dependencies.py).
Ideally, the new Puppet module should not only cover Mercurial, but also allow for using the same mechanisms with Git - in order to allow for testing new code without the requirement to clone and mirror it on hg.adblockplus.org or any other HG entities first.
comment:6 Changed on 02/22/2016 at 04:03:52 PM by trev
- Cc trev added
comment:7 Changed on 02/22/2016 at 04:07:15 PM by matze
- Summary changed from Introduce Mercurial module in Puppet to Introduce SCM module in Puppet
comment:8 Changed on 02/23/2016 at 08:33:01 PM by matze
- Blocking 3663 added
comment:9 Changed on 12/21/2017 at 11:25:42 AM by fhd
- Cc trev removed
comment:10 Changed on 08/26/2019 at 12:00:27 PM by matze
- Resolution set to incomplete
- Status changed from reviewing to closed
This one is obsolete.
Status: @AAlvz, @poz2k4444 and I have actually already started looking into a set of modules for Puppet yesterday; we've just missed the ticket today and realized there's none yet.