Opened on 11/26/2014 at 02:55:35 PM

Closed on 11/26/2014 at 05:13:35 PM

#1613 closed defect (fixed)

Elements loaded from non-HTTP URLs are collapsed

Reported by: passbrains Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.8.8-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6646117731139584

Description (last modified by sebastian)

Adapted from https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=AOP-138

Environment

Windows + Vista 64bit + Chrome/Opera + English
ABP version Adblock Plus Version 1.8.7.1254

How to reproduce

  1. Install ABP extension on Opera.
  1. Load website

http://adventagegroups.com/Index.aspx

  1. Add *.html  in  "Add your own filters"
  2. Select Block element  from ABP menu and click on "Contact us" as shown in html1.jpg

Observe that all menu items would be selected automatically.
5 Check again the ABP icon options. and click on it.
see image html2.jpg

  1. Check again ABP icon options.

 
.

Observed behaviour

Step 5 : Still the Block element option is present.
Step 6. Cancel option  is present instead of "Block element".

Expected behaviour

Step 5 : Cancel  option shall be present instead of "Block element".
Step 6 : "Block element" option shall be present instead of "Cancel".

Attachments (2)

3668_1416587820_html1.jpg (139.7 KB) - added by passbrains on 11/26/2014 at 02:55:38 PM.
3668_1416587820_html2.jpg (148.0 KB) - added by passbrains on 11/26/2014 at 02:55:39 PM.

Download all attachments as: .zip

Change History (5)

Changed on 11/26/2014 at 02:55:38 PM by passbrains

Changed on 11/26/2014 at 02:55:39 PM by passbrains

comment:1 Changed on 11/26/2014 at 03:04:18 PM by sebastian

  • Component changed from Unknown to Platform
  • Description modified (diff)
  • Owner set to sebastian
  • Priority changed from Unknown to P3
  • Ready set
  • Summary changed from [Negative Case]Adding *.html in filter breaks the behavior of block element to Elements loaded from non-HTTP URLs are collapsed

Even though we only do request blocking for http:// and https:// URLs, element collapsing is applied for all elements, including the <iframe> showing chrome-extension://../block.html.

comment:2 Changed on 11/26/2014 at 03:06:20 PM by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 11/26/2014 at 05:13:35 PM by sebastian

  • Description modified (diff)
  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Platform changed from Opera to Unknown
  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sebastian.
 
Note: See TracTickets for help on using tickets.