Opened on 11/26/2014 at 08:52:15 PM

Closed on 03/30/2015 at 10:10:28 AM

Last modified on 10/18/2016 at 02:00:21 PM

#1619 closed change (rejected)

Wrong return value of CPluginClass::Invoke

Reported by: sergz Assignee: sergz
Priority: P3 Milestone: Adblock-Plus-for-Internet-Explorer-1.6
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: Blocked By: #1672
Blocking: Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6453924974297088

Description

Background

It should return at least S_OK (see http://msdn.microsoft.com/en-us/library/windows/desktop/ms221479%28v=vs.85%29.aspx) not VARIANT_TRUE.

What to change

Change the return value.

Attachments (0)

Change History (4)

comment:1 Changed on 11/26/2014 at 08:52:47 PM by sergz

  • Status changed from new to reviewing

comment:2 Changed on 03/16/2015 at 12:13:13 PM by oleksandr

  • Blocked By 1672 added
  • Platform changed from Unknown to Internet Explorer
  • Priority changed from Unknown to P3
  • Ready set

comment:3 Changed on 03/30/2015 at 10:10:28 AM by sergz

  • Resolution set to rejected
  • Status changed from reviewing to closed

After #1672 it's not relevant any more.

comment:4 Changed on 10/18/2016 at 02:00:21 PM by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-Next
  • Tester set to Unknown

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sergz.
 
Note: See TracTickets for help on using tickets.