Opened on 11/27/2014 at 10:24:33 AM
Closed on 06/01/2018 at 04:45:15 PM
#1621 closed change (invalid)
Extend "Remove selected" button on
| Reported by: | sergz | Assignee: | |
|---|---|---|---|
| Priority: | P4 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | sven, greiner | Blocked By: | |
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by greiner)
Background
Currently, showing the "Remove selected" button in the options page makes no sense if nothing is selected from the list because in this case clicking on the button doesn't do anything. Therefore we should reflect that in the UI by disabling the button if nothing is selected.
What to change
On the options page's "Add your own filters" and "Whitelisted domains" tabs, disable the "Remove selected" button when no element is selected in the list next to it. Consequently, that means that it should also be disabled if the list is empty.
Attachments (0)
Change History (4)
comment:1 Changed on 11/27/2014 at 10:47:49 AM by sven
comment:2 Changed on 11/28/2014 at 05:45:49 PM by greiner
- Priority changed from Unknown to P4
comment:3 Changed on 03/31/2015 at 10:40:55 AM by greiner
- Description modified (diff)
- Ready set
Marking it as ready because it appears that the options page redesign will take a while still.
Note that I removed renaming it to "Clear" from the issue description because currently, it doesn't clear the list when nothing is selected.
We handle this problem by doing it differently in the new options page. You can have a look at it here. Therefore i would suggest to make no changes in the current chrome/safari/opera UI.