Opened on 11/28/2014 at 06:19:12 PM
Closed on 12/01/2014 at 12:57:54 PM
Last modified on 10/08/2019 at 05:27:59 PM
#1636 closed defect (duplicate)
Button blocking behavior is improper
| Reported by: | passbrains | Assignee: | |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Unknown | Keywords: | |
| Cc: | greiner, sebastian | Blocked By: | |
| Blocking: | Platform: | Opera | |
| Ready: | no | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description (last modified by sebastian)
Adapted from https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=AOP-134
Environment
Windows + Vista 64bit + Opera + English
ABP version Adblock Plus Version 1.8.7.1254
How to reproduce
- Install ABP extension on Opera.
- Load website
- Block the Like "Yes" and "No" buttons one after other as shown in image1.
- Filter added would be
education-portal.com##.idislike.uplike
education-portal.com##.ilike
- Refresh the page.
- Observe the buttons.
Observed behaviour
Only "Yes" button is blocked but "No" button is NOT blocked.
See image2.
Expected behaviour
Both "Yes" and "No" buttons shall be blocked.
Attachments (3)
Change History (11)
Changed on 11/28/2014 at 06:19:15 PM by passbrains
Changed on 11/28/2014 at 06:19:16 PM by passbrains
Changed on 11/28/2014 at 06:19:17 PM by passbrains
comment:1 Changed on 11/28/2014 at 06:19:22 PM by passbrains
comment:2 follow-up: ↓ 3 Changed on 12/01/2014 at 10:15:02 AM by sebastian
- Cc greiner sebastian added
- Description modified (diff)
If I understand you correctly, this should be fixed with #1603, which moves our event handlers to the capturing phase. Unfortunately I still don't get those buttons, not even when using an incognito session.
comment:3 in reply to: ↑ 2 Changed on 12/01/2014 at 11:29:49 AM by greiner
Replying to sebastian:
If I understand you correctly, this should be fixed with #1603, which moves our event handlers to the capturing phase.
Yes, presumably, that should fix this issue too because the issue is that the page's event handler is triggered before ours.
Unfortunately I still don't get those buttons, not even when using an incognito session.
I got that other design by switching to a different Chrome profile.
comment:4 Changed on 12/01/2014 at 11:56:23 AM by sebastian
Well, #1603 is already fixed. So if you can reproduce the issue with the devbuild, it's something else.
comment:5 Changed on 12/01/2014 at 12:45:28 PM by greiner
- Resolution set to fixed
- Status changed from new to closed
Right, I can confirm that.
comment:6 Changed on 12/01/2014 at 12:56:52 PM by sebastian
- Resolution fixed deleted
- Status changed from closed to reopened
comment:7 Changed on 12/01/2014 at 12:57:54 PM by sebastian
- Resolution set to duplicate
- Status changed from reopened to closed
Since this is the same issue as fixed by #1603, the reolution should be duplicate.
comment:8 Changed on 05/16/2019 at 07:20:36 AM by Himanshu0709
spam
1 - 26 Nov 2014 12:55:35 posted by Sebastian Noack
Those buttons doesn't exist anymore on that website.
2 - 26 Nov 2014 15:18:37 posted by Garima Agrawal
Dear Sebastian,
I am able to see those buttons still. Attaching snapshot.
Please check.
Rgds
Garima
3 - 28 Nov 2014 18:18:55 posted by Thomas Greiner
The reason why Sebastian and me cannot see it is because they are showing a different page design to us. In a different browser session, however, I was able to get the one shown in the screenshots which allowed me to reproduce the issue.
The issue is that the page's click listener is triggered and modifies the underlying element which causes the extension to create a suboptimal filter.