Opened on 12/02/2014 at 01:06:32 PM
Closed on 12/03/2014 at 01:54:41 PM
#1644 closed defect (fixed)
<input type=image> elements are recognized with the wrong type on Safari
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P4 | Milestone: | Adblock-Plus-1.8.9-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Environment
Safari
How to reproduce
- Go to options
- Add custom filter: ||www.aweber.com/images/forms/sign-up-below/small-red/button.png^$image
- Go to http://www.softwaretestinghelp.com
Observed behaviour
The "Sign In" button isn't blocked. That is because the filter is limited to images with the $image filter option, but <input type=image> elements are reported with the type other instead.
Expected behaviour
<input type=image> elements should be reported with the type image (as they are on Chrome), matching filters using the $image filter option. So the "Sign In" button should be blocked here.
Attachments (0)
Change History (2)
comment:1 Changed on 12/02/2014 at 01:07:39 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 12/03/2014 at 01:54:41 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
https://hg.adblockplus.org/adblockpluschrome/rev/5dbb73e16103