Opened on 12/03/2014 at 01:34:48 PM
Closed on 12/03/2014 at 05:52:35 PM
#1655 closed change (fixed)
Adding the "short_name" to our Chrome manifest
| Reported by: | jobp | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P4 | Milestone: | |
| Module: | Automation | Keywords: | growth |
| Cc: | greiner | Blocked By: | |
| Blocking: | Platform: | Chrome | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description (last modified by greiner)
Background
By adding the "short_name" to the Chrome manifest, we hope that it'll have a positive effect on the search indexing on search engines and the CWS.
What to change
Add "Adblock Plus" as the "short_name" in the Chrome manifest.
Attachments (0)
Change History (6)
comment:1 Changed on 12/03/2014 at 01:45:18 PM by sebastian
comment:2 Changed on 12/03/2014 at 01:48:58 PM by greiner
- Description modified (diff)
According to the Chrome Developers page it is shown on the New Tab page and in the App launcher so while it might not be visible to our users right now it could very well be used in other places in the future. Therefore I agree that we should use "Adblock Plus" instead.
comment:3 Changed on 12/03/2014 at 01:54:07 PM by jobp
Agreed. "Adblock Plus" it is.
comment:4 Changed on 12/03/2014 at 03:16:43 PM by sebastian
- Cc sebastian removed
- Component changed from Unknown to Build-and-Release-Tools
- Keywords growth added
- Owner set to sebastian
- Priority changed from Unknown to P4
- Ready set
comment:5 Changed on 12/03/2014 at 03:37:51 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:6 Changed on 12/03/2014 at 05:52:35 PM by sebastian
- Resolution set to fixed
- Status changed from reviewing to closed
https://hg.adblockplus.org/buildtools/rev/a4a36496f000
This change doesn't have any effect, until the buildtools dependency is updated. I will update the dependencies a week prior to the release. So starting with next release short_name will be set.
Maybe we should use "Adblock Plus" also as short_name, since it can be up to 12 chars. We don't know whether/where the short name is shown, and if it is shown to the user, it will be confusing since there is another adblocker called just "AdBlock".