Opened on 12/04/2014 at 04:25:12 PM
Closed on 12/08/2014 at 05:32:21 PM
#1658 closed defect (fixed)
"Block element" adds semicolon to style attributes
| Reported by: | passbrains | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P4 | Milestone: | Adblock-Plus-1.8.9-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description (last modified by sebastian)
Adapted from https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=AOP-157
Environment
ABP version Adblock Plus Version 1.8.7.1271
How to reproduce
Pre-conditions :
- ABP Extension is installed on Opera Desktop Browser.
- ABP is enabled. Check ABP version as 1.8.7.1271
- ABP Options : Easylist = Enabled, No filters added, Whtielisted domains = Empty,
Show 'Block Element' right-click menu item = Checked,
Hide placeholders of blocked elements = Uncheked.
Steps :
- Go to http://www.xmlfiles.com/examples/tryit.asp?filename=note
- Block the left side textarea. as shown in pink in snapshot1
Filter added would be :
www.xmlfiles.com##textarea[style="width: 100%; height: 90%;"]
- textarea would be blocked.
- refresh the page. Observe.
Observed behaviour
On refresh blocked textarea reappears.
Expected behaviour
Blocked element shall not appear again on refresh.
Attachments (1)
Change History (5)
Changed on 12/04/2014 at 04:25:15 PM by passbrains
comment:1 Changed on 12/04/2014 at 04:32:38 PM by sebastian
- Cc sebastian added
- Component changed from Unknown to Platform
- Description modified (diff)
- Platform changed from Opera to Unknown
- Priority changed from Unknown to P4
- Ready set
- Summary changed from Block element does not work well on textarea to "Block element" adds semicolon to style attributes
comment:2 Changed on 12/04/2014 at 05:23:07 PM by sebastian
- Cc sebastian removed
- Owner set to sebastian
comment:3 Changed on 12/04/2014 at 05:23:18 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 12/08/2014 at 05:32:21 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
The style attribute in the generated element hiding filter has a trailing semicolon, while the style attribute of the element didn't have a trailing semicolon, before it was selected. That is because we add additional styles to the element in order to highlight it, and when removing those styles, Chrome preserves a trailing semicolon.