Opened on 12/06/2014 at 12:30:51 PM

Closed on 12/10/2014 at 08:23:17 AM

Last modified on 01/08/2015 at 04:28:22 PM

#1668 closed defect (fixed)

Extension pages use wrong direction for right-to-left languages

Reported by:	sebastian	Assignee:	sebastian
Priority:	P3	Milestone:	Adblock-Plus-2.6.7-for-Firefox
Module:	User-Interface	Keywords:
Cc:	greiner, sven, trev	Blocked By:
Blocking:		Platform:	Unknown
Ready:	yes	Confidential:	no
Tester:		Verified working:	no
Review URL(s):	http://codereview.adblockplus.org/5137457368530944

Description (last modified by sebastian)

Environment

Chrome, Opera, Safari and Firefox with an right-to-left language (like Arabic or Hebrew)

Observed behaviour

On the first run page the texts and layout flows from left to right.

The same with the options page, popup UI and "Block element" dialog, on Chrome Opera and Safari.

Expected behaviour

Text and layout must flow from right to left in Arabic and Hebrew.

Change History (11)

comment:1 Changed on 12/08/2014 at 12:01:02 PM by sebastian

Cc trev added

comment:2 Changed on 12/08/2014 at 12:01:39 PM by sebastian

Summary changed from Layout direction must be right-to-left or Arabic and Hebrew to Layout direction must be right-to-left in Arabic and Hebrew

comment:3 Changed on 12/08/2014 at 06:30:31 PM by sebastian

Owner set to sebastian

comment:4 Changed on 12/08/2014 at 07:05:50 PM by sebastian

Description modified (diff)
Review URL(s) modified (diff)
Status changed from new to reviewing

comment:5 Changed on 12/09/2014 at 06:41:14 AM by sebastian

Description modified (diff)

comment:6 Changed on 12/09/2014 at 05:59:23 PM by sebastian

Blocked By 1678 added

comment:7 Changed on 12/09/2014 at 06:06:03 PM by sebastian

Description modified (diff)
Summary changed from Layout direction must be right-to-left in Arabic and Hebrew to Extension pages use wrong direction for right-to-left languages

comment:8 Changed on 12/10/2014 at 08:23:17 AM by sebastian

Blocked By 1678 removed
Resolution set to fixed
Status changed from reviewing to closed

https://hg.adblockplus.org/adblockplus/rev/5dc02d944588

Last edited on 12/10/2014 at 10:38:31 AM by sebastian

comment:9 Changed on 01/07/2015 at 10:01:08 PM by ItielMaN

Thanks sebastian, the new RTL UI is almost perfect, you only forgot RTLing the tabs on the options page..
They should be also RTL'd.

comment:10 Changed on 01/07/2015 at 10:10:33 PM by sebastian

Thanks for pointing this out. This should be considered for the new options page (#1524).

comment:11 Changed on 01/08/2015 at 04:28:22 PM by trev

Milestone set to Adblock-Plus-for-Firefox-next

Context Navigation