Opened on 12/08/2014 at 10:48:40 AM
Closed on 12/11/2014 at 02:50:18 PM
#1670 closed change (fixed)
Remove "Hide placeholders" option from the UI on Firefox
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-2.6.7-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | trev, greiner | Blocked By: | |
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Background
The effect of that option is limitted and confusing, since it doesn't have any effect on element hiding. Also we assume only very few users using this option.
But for now, we only want to remove that option from the UI. So if users complain about that change, they can disable element collapsing again on the console.
What to change
Remove the "Hide placeholders" option from the options page and reset the option, always collapsing blocked elements. However, keep the functionlity in there for now.
Attachments (0)
Change History (6)
comment:1 Changed on 12/08/2014 at 10:50:44 AM by sebastian
comment:2 Changed on 12/08/2014 at 11:33:17 AM by philll
Why should we want to reset the option for users that had deselected this choice?
comment:3 Changed on 12/08/2014 at 12:27:23 PM by trev
The reasoning is that users won't be able to find this option again if they want to revert their choice. If we are hiding the option, we should make sure that everybody is back on the default - and if they change settings via about:config later they will know where to find them again.
comment:4 Changed on 12/08/2014 at 12:30:45 PM by sebastian
Because it would be confusing when users experience inconsistent behavior, without having the UI reflect that option. In particular users which just temporary disabled element collapsing, will be helpless when they want to enable it again.
I also assume that collapsing elements is the general preferred behavior here. So by resetting that setting we will fix the behavior for those who changed that setting without knowing what they do.
However, if somebody really wants to disable element collapsing, they can still do so with about:config. In this case the user knows how to configure hidden options, and how to enable it again.
comment:5 Changed on 12/08/2014 at 05:11:54 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:6 Changed on 12/11/2014 at 02:50:18 PM by sebastian
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
See #1671, for respective Chrome/Opera/Safari issue.