Opened on 12/13/2014 at 03:47:48 PM
Closed on 12/16/2014 at 02:05:17 PM
Last modified on 12/30/2014 at 02:56:32 AM
#1694 closed defect (fixed)
Popup menu doesn't work when opening multiple tabs simultaneously on Safari
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-1.8.9-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Safari | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Environment
Safari 8
How to reproduce
- Open the "View" menu
- Enable "Show favorites bar"
- Click a Category for the Favorites bar with multiple item (e.g. "News")
- Click "Open in tabs" (that means open all pages in that category)
- Click the ABP icon
- Click "Options"
Observed behaviour
Nothing happens.
Expected behaviour
The option page should be opened.
Attachments (0)
Change History (4)
comment:1 Changed on 12/13/2014 at 03:52:05 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 12/15/2014 at 03:24:05 PM by philll
- Platform changed from Unknown to Safari
comment:3 Changed on 12/16/2014 at 02:05:17 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 12/30/2014 at 02:56:32 AM by sebastian
- Summary changed from Popup menu doesn't work when opening multiple tabs to Popup menu doesn't work when opening multiple tabs simultaneously on Safari
Note: See
TracTickets for help on using
tickets.
That is because the current tab get immediately replaced, hence SafariBrowserTab.browserWindow doesn't exist when isPageActive() is called, resulting into an error breaking the popup.