Opened on 12/14/2014 at 10:06:35 AM

Closed on 02/19/2015 at 10:07:06 PM

#1696 closed change (fixed)

[sitescripts] Make it possible to add URL handlers not in sitescripts

Reported by: fhd Assignee:
Priority: P2 Milestone:
Module: Sitescripts Keywords:
Cc: Blocked By:
Blocking: #1697 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5391933643948032/

Description (last modified by fhd)

Background

Currently, URL handlers need to be children of the sitescripts module, and thus in the sitescripts repository. We'd be more flexible if we could configure URL handlers that aren't in the sitescripts repository.

The current use case is to add an update check URL handler for a product we haven't announced yet.

What to change

Currently, URL handlers are configured like this:

[multiplexer]
sitescripts.foo.bar =

Conveniently, we ignore the value so far. We can use that for the module's full path, e.g.:

[multiplexer]
not_sitescripts.foo.bar = /wherever/foo/bar.py

Entries without a value would be considered to be in sitescripts, as they are currently.

Attachments (0)

Change History (5)

comment:1 Changed on 12/14/2014 at 10:07:46 AM by fhd

  • Description modified (diff)

comment:2 Changed on 12/14/2014 at 10:08:50 AM by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 12/14/2014 at 10:27:44 AM by fhd

  • Blocking 1697 added

comment:4 Changed on 02/19/2015 at 01:40:49 PM by sebastian

  • Component changed from Infrastructure to Sitescripts

comment:5 Changed on 02/19/2015 at 10:07:06 PM by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
 
Note: See TracTickets for help on using tickets.