Opened on 12/28/2014 at 01:25:54 PM
Closed on 01/07/2015 at 02:37:27 PM
#1739 closed change (fixed)
Respect MessageSender.frameId on Chrome 41+
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-1.8.10-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | ||
| Review URL(s): | |||
Description
Background
Currently we iterate over all previously seen frames comparing the URL, to figure out the sender's frame in chrome.runtime.onMessage. This approach is inefficient and error-prone. But before Chrome 41 this was the best we could do. However, Chrome 41 introduces MessageSender.frameId, making that hack obsolete.
What to change
Rely on MessageSender.frameId if available to identify the sender's frame in chrome.runtime.onMessage.
Attachments (0)
Change History (2)
comment:1 Changed on 12/28/2014 at 01:28:04 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 01/07/2015 at 02:37:27 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
https://hg.adblockplus.org/adblockpluschrome/rev/f82eb513fc82