Opened on 01/04/2015 at 06:24:03 PM
Closed on 01/13/2015 at 02:21:14 PM
#1751 closed defect (fixed)
"Block element" doesn't highlight (whole area of) elements if the background isn't (fully) visible
| Reported by: | passbrains | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-1.8.10-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | mapx | Blocked By: | |
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | ||
| Review URL(s): | |||
Description (last modified by sebastian)
Adapted from https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=ASA-32
Environment
Chrome, Opera, Safari
How to reproduce
- Install Adblock Plus extension in Safari 6.1.1 browser
- Load www.passbrains.com page
- Click ABP button
- Click Block element option
- Hover carousel element on the page and make sure only it is highlighted
- Observe main page content and see it becomes blank
Observed behaviour
The element .all-centered is blocked, but only parts of it were highlighted.
Expected behaviour
The whole element to be blocked should be highlighted.
Attachments (3)
Change History (9)
Changed on 01/04/2015 at 06:24:05 PM by passbrains
Changed on 01/04/2015 at 06:24:06 PM by passbrains
Changed on 01/04/2015 at 06:24:08 PM by passbrains
comment:1 Changed on 01/04/2015 at 10:14:49 PM by mapx
- Description modified (diff)
Last edited on 01/04/2015 at 10:19:37 PM
by mapx
comment:2 Changed on 01/04/2015 at 10:15:40 PM by mapx
- Cc mapx added
comment:3 Changed on 01/05/2015 at 03:27:42 PM by sebastian
- Component changed from Unknown to Platform
- Description modified (diff)
- Owner set to sebastian
- Platform changed from Safari to Unknown
- Priority changed from Unknown to P3
- Ready set
- Summary changed from Blocking carousel on www.passbrains.com page blocks whole the page to "Block element" doesn't highlight (whole area of) elements if the background isn't (fully) visible
The problem is that the selected element is highlighted by changing it's background color and applying an inset shadow. Hence, the highlighting of elements whose background is covered by child elements, isn't (fully) visible. We should inject an overlay covering the element to highlight, instead.
Last edited on 01/05/2015 at 03:30:50 PM
by sebastian
comment:4 Changed on 01/05/2015 at 03:35:23 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:6 Changed on 01/13/2015 at 02:21:14 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
You didn't highlight only the carousel !
if you select only the slide with left/right sides and not the upper part above the slide you'll find the correct filter
I tried this in chrome but I guess is the same for safari