Opened on 01/08/2015 at 04:14:45 AM
Closed on 11/10/2017 at 11:15:18 AM
#1764 closed change (rejected)
Add API to indicate the filters have been loaded
| Reported by: | her34 | Assignee: | |
|---|---|---|---|
| Priority: | P4 | Milestone: | |
| Module: | Adblock-Plus-for-Firefox | Keywords: | goodfirstbug |
| Cc: | trev | Blocked By: | |
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by trev)
Background
Adblock Plus provides an API for external extensions to use. However, the external extensions have no way of knowing whether ABP is actually ready - the component will be available before the filters load.
What to change
There are two possible ways to solve this. One would be an additional API, e.g. a boolean IAdblockPlus.filtersLoaded plus a way to add listeners that will be notified when Adblock Plus filters load.
However, given that IAdblockPlus is very much about filters, it should be preferable to only register the corresponding component once the filters are actually available. These would remove the scenario where the API is available but cannot really be used.
Attachments (0)
Change History (11)
comment:1 Changed on 01/08/2015 at 09:51:04 AM by trev
- Cc trev added
- Component changed from Unknown to Adblock-Plus-for-Firefox
- Description modified (diff)
- Platform changed from Unknown to Firefox/Firefox Mobile
- Priority changed from Unknown to P4
- Ready set
- Summary changed from Request: api to report ABP is fully loaded to Add API to indicate the filters have been loaded
- Type changed from defect to change
comment:2 Changed on 01/08/2015 at 09:54:32 AM by trev
- Keywords goodfirstbug added
comment:3 Changed on 01/15/2015 at 07:06:38 PM by Mailkov
comment:4 Changed on 01/15/2015 at 09:05:53 PM by trev
- Owner set to Mailkov
Sure. Let me know if you have questions.
comment:5 follow-up: ↓ 9 Changed on 02/27/2015 at 06:32:42 AM by Mailkov
Pull request:https://github.com/adblockplus/adblockplus/pull/9
comment:6 Changed on 03/20/2015 at 04:33:16 PM by trev
- Owner Mailkov deleted
Unassigning - no progress, maybe somebody else wants to work on this.
comment:7 Changed on 03/23/2015 at 04:23:52 PM by Mailkov
You could contact me before unsubscribe.
comment:8 Changed on 05/20/2015 at 02:22:39 PM by philll
- Platform changed from Firefox/Firefox Mobile to Firefox
Made Firefox and Firefox mobile available as seperate platforms.
comment:9 in reply to: ↑ 5 Changed on 01/15/2016 at 08:05:21 PM by erikvold
- Tester set to Unknown
- Verified working unset
Replying to Mailkov:
Pull request:https://github.com/adblockplus/adblockplus/pull/9
This appears to be a dead link, did something happen to it?
comment:10 Changed on 01/15/2016 at 08:43:23 PM by trev
Yes, our hg to git sync broke and we couldn't find any way to fix this other than resetting the repository :-(
comment:11 Changed on 11/10/2017 at 11:15:18 AM by trev
- Resolution set to rejected
- Status changed from new to closed
Mass-closing all bugs in Adblock Plus for Firefox module, the codebase of Adblock Plus 3.0 belongs into Platform and User-Interface modules. Old bugs are unlikely to still apply.
Hi , I would like to work on this change