Opened on 01/10/2015 at 12:18:31 AM

Closed on 02/02/2015 at 12:37:44 PM

Last modified on 05/20/2015 at 02:22:39 PM

#1773 closed defect (fixed)

[Typed objects] "assignment to undeclared variable bufferOffset" in unit tests

Reported by: trev Assignee: trev
Priority: P2 Milestone:
Module: Core Keywords:
Cc: Blocked By:
Blocking: #145 Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

​http://codereview.adblockplus.org/6155997320052736/

Description

Environment

Firefox 34, Chrome 39.

How to reproduce

  1. Run unit tests for typed objects.

Observed behaviour

"assignment to undeclared variable bufferOffset" error in Array memory allocation test - erroring out due to "use strict".

Expected behaviour

The tests succeed.

Attachments (0)

Change History (4)

comment:1 Changed on 01/10/2015 at 12:18:41 AM by trev

  • Ready set

comment:2 Changed on 01/10/2015 at 12:20:44 AM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 02/02/2015 at 12:37:44 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed: ​https://hg.adblockplus.org/adblockpluscore/rev/5c50e322484a

comment:4 Changed on 05/20/2015 at 02:22:39 PM by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.