Opened on 01/13/2015 at 10:25:39 AM
Closed on 01/16/2015 at 03:41:08 PM
#1784 closed change (fixed)
"Block popup for this website" is added to the ABP UI, but is browser functionality
| Reported by: | jobp | Assignee: | jobp |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Unknown | Keywords: | |
| Cc: | sven | Blocked By: | |
| Blocking: | Platform: | Maxthon | |
| Ready: | no | Confidential: | no |
| Tester: | Verified working: | ||
| Review URL(s): | |||
Description (last modified by jobp)
Environment
ABP for Maxthon has a "Block popup for this website" feature for both the Chinese and International version. This calls the "window.open" function, and is not Adblock Plus functionality.
Also, when the function is called, it loads empty elements in the UI - see attachment for more information.
How to reproduce
- Launch Maxthon beta 4.4.4.800
- Go to a random website (e.g. cnn.com)
- Click on ABP icon, and see the "Block popup for this website" element in the UI
Solution
This feature should be designed/implemented in such a way that it is clear that it is a browser (or Maxthon) feature.
Attachments (1)
Change History (11)
Changed on 01/13/2015 at 02:16:01 PM by jobp
comment:4 Changed on 01/13/2015 at 02:25:45 PM by jobp
- Summary changed from "Block popup for this website" feature to "Block popup for this website" is added to the ABP UI, but is browser functionality
comment:5 Changed on 01/13/2015 at 03:31:03 PM by jobp
- Type changed from defect to change
comment:8 Changed on 01/16/2015 at 03:40:35 PM by jobp
comment:9 Changed on 01/16/2015 at 03:40:46 PM by jobp
- Owner set to jobp
comment:10 Changed on 01/16/2015 at 03:41:08 PM by jobp
- Resolution set to fixed
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
Almost fixed, we have to agree on a UI. No problems expected there. We should be able to communicate the suggestions on Monday.