Opened on 03/20/2014 at 06:56:09 AM
Closed on 03/20/2014 at 05:39:59 PM
Last modified on 04/13/2014 at 06:30:19 PM
#179 closed change (fixed)
Make sure webRequest listener never throws exceptions
| Reported by: | trev | Assignee: | |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-1.8-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | chrome |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | ||
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Background
http://code.google.com/p/chromium/issues/detail?id=349139 introduced a change in webRequest behavior with the effect that an exception in the webRequest listener cancels the request. For us this means that our listener should never throw an exception.
What to change
We need to wrap the webRequest listener in a try..catch block and only log exceptions. The default should be to allow the request, not to block it.
Attachments (0)
Change History (5)
comment:1 Changed on 03/20/2014 at 06:59:04 AM by trev
- Keywords chrome added
- Ready set
comment:2 Changed on 03/20/2014 at 03:19:51 PM by sebastian
- Status changed from new to reviewing
comment:4 Changed on 03/20/2014 at 05:39:59 PM by sebastian
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 04/13/2014 at 06:30:19 PM by trev
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
Note: See
TracTickets for help on using
tickets.
http://codereview.adblockplus.org/5328346325975040/