Opened on 01/14/2015 at 05:36:28 AM
Closed on 01/22/2015 at 09:57:10 AM
Last modified on 01/22/2015 at 03:36:51 PM
#1802 closed defect (fixed)
Only first selector in multi-selector hiding rule works in Chrome
| Reported by: | Lain_13 | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-1.8.11-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | mapx | Blocked By: | |
| Blocking: | Platform: | Chrome | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | ||
| Review URL(s): | |||
Description
Environment
OS: Windows 7 Ultimate SP1
Chrome: Version 39.0.2171.95 m
Adblock Plus: 1.8.9
Lists (doesn't matter): EasyList + RU Adlists + Anticounter and Bitblock from RU Adlist site.
How to reproduce
- Add filter issues.adblockplus.org###logo,#search
- Refresh this page.
Observed behaviour
Only logo in the top-left corner are hidden. In Firefox browser it works as expected.
Expected behaviour
Both logo in the top-left corner and search string with search button in the top-right corner have to disappear since multiple selectors divided with a comma is a valid selector as well.
Attachments (0)
Change History (8)
comment:1 Changed on 01/14/2015 at 08:10:32 AM by mapx
- Cc sebastian mapx added
comment:2 Changed on 01/14/2015 at 10:26:02 AM by sebastian
- Cc sebastian removed
- Component changed from Unknown to Platform
- Owner set to sebastian
- Priority changed from Unknown to P3
- Ready set
comment:3 Changed on 01/14/2015 at 10:27:48 AM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 01/22/2015 at 08:07:40 AM by sebastian
- Blocking 1844 added
comment:5 Changed on 01/22/2015 at 09:14:50 AM by sebastian
- Blocking 1844 removed
comment:6 Changed on 01/22/2015 at 09:57:10 AM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:7 Changed on 01/22/2015 at 03:12:53 PM by sebastian
- Blocking 1853 added
comment:8 Changed on 01/22/2015 at 03:36:51 PM by sebastian
- Blocking 1853 removed
Note: See
TracTickets for help on using
tickets.
This is because we add ::content (to break out of the shadow DOM) only to the beginning of the CSS selector string. However, it needs to be added after every , (except those inside quotes) as well.