Port icon popup from Chrome, Opera and Safari to Firefox

[greiner]

Background

In continuation to the ongoing redesign we redid the icon popup in Chrome, Opera and Safari.

What to change

Move the popup's HTML code into Adblock Plus for Firefox, implement the icon popup on there and reuse it in Chrome, Opera and Safari.
List of subtickets:

Ticket	Status	Resolution	Summary	Component	Owner
#1435	closed	rejected	[Bubble UI] Port popup.html from Chrome/Safari/Opera to Firefox	Adblock-Plus-for-Firefox	saroyanm
#1436	closed	rejected	[Bubble UI] Add Enable/Disable functionality	Adblock-Plus-for-Firefox
#1437	closed	rejected	[Bubble UI] Implement Notifications	Adblock-Plus-for-Firefox
#1438	closed	rejected	[Bubble UI] Add "Statistics" functionality with Ads blocked element	Adblock-Plus-for-Firefox
#1439	closed	rejected	[Bubble UI] Badge implementation	Adblock-Plus-for-Firefox
#1440	closed	rejected	[Bubble UI] Make new Bubble UI compatible with additional ABP Addons.	Adblock-Plus-for-Firefox
#1445	closed	rejected	[Bubble UI] No type attribute in toolbarbutton	Adblock-Plus-for-Firefox

After all subtickets are implemented we need to merge ​bubbleui-firefox repository from bitbucket to ​adblockplus repository.

[greiner]

Further details as provided by Wladimir:

• replace native Firefox menu with HTML page from Chrome, Opera and Safari embedded into <panel type="arrow">
• adapt page to account for differing features in the Firefox version (some options can be dropped)
• necessary functionality from ext.* abstraction layer needs to be added since it doesn't exist in the Firefox version
• the background page will have to be faked
• extensions to Adblock Plus (e.g. Diagnostics) need to be added to the popup menu somehow (currently, they're listening for the popupshowing event)

[trev]

This is planned, no urgency here - P2. Also removed milestone - this is unlikely to make it into the next Firefox release. Currently we only set milestones when an issue is resolved.

[philll]

The assigned state will be dropped by #403

[fhd]

Since this is going to implement the platform abstraction layer we have in Chrome/Opera/Safari for Firefox, can you add the relevant code paths to ​https://adblockplus.org/en/modules when it's done?

[saroyanm]

I've filed a bug on for the remaining issue we have that prevent us from puting the ticket under review, hope we will get response soon from Mozilla developers.
​https://bugzilla.mozilla.org/show_bug.cgi?id=1062974

[saroyanm]

While the bug mentioned above affects MAC OSX, there is another bug that affects both Windows and Linux:
​https://bugzilla.mozilla.org/show_bug.cgi?id=1063097

[saroyanm]

After investigating the Bubble UI further it's came out that the issue is not related to panel of type arrow, but to the toolbarbutton of current types: panel, menu and menu-button.

So the good news are that we can use ​openPopup method to open the popup and don't use toolbarbutton type attribute.

Also one question would like to align: while the issue affects the toolbarbutton we can still have panel with arrow on the top, but while before we were not using panel with arrow and after aligning with Wladimir I just would like to raise a question whether we want arrow in the panel or not, so what you think guys should we have arrow in the top of popup or stick to the older popup style without arrow ?

[trev]

Also one question would like to align: while the issue affects the toolbarbutton we can still have panel with arrow on the top, but while before we were not using panel with arrow and after aligning with Wladimir I just would like to raise a question whether we want arrow in the panel or not, so what you think guys should we have arrow in the top of popup or stick to the older popup style without arrow ?

Sven, any opinion? Firefox convention is that toolbar buttons with a dropdown of some kind (which would include our bubble) should have a dropdown arrow. However, Firefox currently violates this convention itself with the bookmark icon (granted, it only shows a bubble on the second click). Also, our icon doesn't have this dropdown arrow in Chrome or Safari. Essentially, it is platform consistency vs. product consistency.

[saroyanm]

Replying to trev:

Sven, any opinion? Firefox convention is that toolbar buttons with a dropdown of some kind (which would include our bubble) should have a dropdown arrow. However, Firefox currently violates this convention itself with the bookmark icon (granted, it only shows a bubble on the second click). Also, our icon doesn't have this dropdown arrow in Chrome or Safari. Essentially, it is platform consistency vs. product consistency.

Wladimir, so just for clarification as far as I understand you mean the dropdown arrow which is on the right side of toolbarbutton icon, not the arrow that is specified by <panel type="arrow"> ?
Maybe in that case we should also think about the case of changing the default toolbar action, I think in case of left click action change using ABP customization maybe we will still need that dropdown there.

[sven]

Replying to saroyanm:

Replying to trev:

Sven, any opinion? Firefox convention is that toolbar buttons with a dropdown of some kind (which would include our bubble) should have a dropdown arrow. However, Firefox currently violates this convention itself with the bookmark icon (granted, it only shows a bubble on the second click). Also, our icon doesn't have this dropdown arrow in Chrome or Safari. Essentially, it is platform consistency vs. product consistency.

Wladimir, so just for clarification as far as I understand you mean the dropdown arrow which is on the right side of toolbarbutton icon, not the arrow that is specified by <panel type="arrow"> ?
Maybe in that case we should also think about the case of changing the default toolbar action, I think in case of left click action change using ABP customization maybe we will still need that dropdown there.

I see both variants in firefox extensions. Ghostery for example has no arrow but Greasemonkey has. I think that it makes most sense if we implement it on every platform in the same way. So the conclusion would be: no arrow down for firefox anymore since we have no arrow at other platforms.

[saroyanm]

Guys I have a question about Badge implementation in Seamonkey,
The badged type for toolbarbutton in Seamonkey looks not to implemented, but in Firefox we can use the badge freely, so I would like to align if we really need the badge for showing hit statistics on active page in Seamonkey or not ?
In case we need badge also in Seamonkey seams to be we need to implement the badge ourself and don't use Firefox implementation for it.

[saroyanm]

After discussing today with Wladimir the Bubble UI implementation looks like we'll need to implement the badge ourselves and don't use Firefox implementation because it's not documented and the implementation looks more to be for internal use.

Also we will need to split the patch and create several subtickets to make the review process not be much complicated with a one huge patch.

[saroyanm]

There is a ​new repository for this issue in bitbucket where we are going to push changes before merging with ​adblockplus repo.

[greiner]

Keep in mind that we also need to backport these changes to Platform and update the subrepository.

[saroyanm]

Replying to greiner:

Keep in mind that we also need to backport these changes to Platform and update the subrepository.

Yes I've added a new Blocking ticket #1461.

[jobp]

Any chance we can get this with a slightly higher priority for the upcoming quarter? This project has been laying around for over 9 months, and we are missing out that 17MM daily active users are unable to share ABP through the bubble UI.

Would be awesome if we can squeeze this in.

[philll]

This issue is part of the current roadmap and thus already the highest non-bug or business-endangering priority. If there wasn't too much progress here, the reason is for sure not the priority.

[jobp]

Replying to philll:

If there wasn't too much progress here, the reason is for sure not the priority.

Fair enough.

Then it looks like nobody really picked it up - even though the P2 was set 9 months ago.
@Thomas: Since you are the module owner of our UIs, mind helping to push for this?

[saroyanm]

Replying to jobp:

Then it looks like nobody really picked it up - even though the P2 was set 9 months ago.

Subticket is pending a review, so in case you would like to increase priority, or push the ticket, make sense to do so with subticket, in this case #1435, I think it's the biggest subticket, so other ones should go much more quicker.

[jobp]

Ok, thanks.

[greiner]

Since we now have the adblockplusui repository for shared UI components it makes more sense to move it there and then make use of it in Adblock Plus for Firefox. It should also make use of the recently introduced front-end messaging API to ensure compatibility with e10s.

For that we need to adapt all of the existing issues and extend and clarify their descriptions before we can start working on those again.

[fhd]

This doesn't seem to qualify as a P2 anymore, changing to P3.

[sebastian]

With traditional Firefox extensions to be deprecated, and Adblock Plus for Firefox to be replaced with something that is build directly from adblockpluschrome the effort here becomes obsolete.