Opened on 01/16/2015 at 01:27:00 PM
Closed on 01/16/2015 at 04:33:39 PM
#1824 closed change (fixed)
Remove unused method Page.activate()
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P4 | Milestone: | Adblock-Plus-1.8.10-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | goodfirstbug |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | ||
| Review URL(s): | |||
Description
Background
Initially we used Page.activate() to bring up a previous opened tab showing the options page, instead opening a new tab. However, since #1268 this logic is implemented in ext.openOptions() using native extension APIs directly. Therfore Page.activate() is unused and can be removed now.
What to change
Remove Page.activate() from the abstraction layer.
Attachments (0)
Change History (2)
comment:1 Changed on 01/16/2015 at 01:28:32 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 01/16/2015 at 04:33:39 PM by sebastian
- Milestone set to Adblock-Plus-1.8.10-for-Chrome-Opera-Safari
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
https://hg.adblockplus.org/adblockpluschrome/rev/d511bd021fcf