Opened on 01/22/2015 at 03:12:53 PM
Closed on 03/03/2015 at 03:01:17 PM
#1853 closed change (fixed)
Move filter generation into the background page utilizing URL utils available there
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-1.8.12-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | #1801 | |
| Blocking: | #1282, #2076 | Platform: | Unknown |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | ||
| Review URL(s): | |||
Description (last modified by sebastian)
Background
With #1801 we introduced URL objects and some IDN-aware helper functions in the background page. But the "Block element" functionality still generates filters in the content script, handling URLs in an obsolete way. In order to unify code and make "Block element" correctly handle IDN domains we have to move the filter generation to the background page. This will also simplify the implementation of #1282.
What to change
Move the generation of filters from the content script to the background page, parsing/resolving URLs there.
Attachments (0)
Change History (4)
comment:1 Changed on 01/22/2015 at 03:20:28 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 01/22/2015 at 03:36:51 PM by sebastian
- Blocked By 1801 added; 1802 removed
- Description modified (diff)
comment:3 Changed on 03/02/2015 at 04:16:30 PM by sebastian
- Blocking 2076 added
comment:4 Changed on 03/03/2015 at 03:01:17 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
https://hg.adblockplus.org/adblockpluschrome/rev/b18804fc9913