Opened on 03/21/2014 at 01:46:40 PM
Closed on 05/09/2014 at 06:13:29 AM
#186 closed defect (fixed)
[seamonkey] disabled ABP icon in tool bar re-appears after seamonkey restart
| Reported by: | philll | Assignee: | saroyanm |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-2.6.1-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | ||
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Environment
Win 7 Enterprise
Seamonkey 2.25
ABP 2.5.1
Taken from https://adblockplus.org/forum/viewtopic.php?f=11&t=20587#p90771
How to reproduce
- Rightclick the ABP icon
- Ensure "Options/Show in toolbar" is not checked
- Restart Seamonkey
Observed behaviour
The ABP icon formerly disabled reappears.
Expected behaviour
The ABP icon disabled should not reappear.
Attachments (0)
Change History (7)
comment:1 Changed on 03/21/2014 at 01:47:41 PM by philll
comment:2 Changed on 04/24/2014 at 08:33:44 AM by philll
- Priority changed from P3 to P2
comment:3 Changed on 04/25/2014 at 01:19:26 PM by philll
- Ready set
comment:4 Changed on 05/05/2014 at 07:41:16 AM by saroyanm
- Owner set to saroyanm
comment:5 Changed on 05/05/2014 at 11:18:00 AM by saroyanm
Seams like when the ABP icon is being removed from toolbar, the icon is not being removed fully, but placed under BrowserToolbarPalette for seamonkey.
So the toolbox.ownerDocument.getElementById("abp-toolbarbutton"); does not return null when the button is not being shown:
https://hg.adblockplus.org/adblockplus/file/d76e8603bcb9/lib/customizableUI.js#l182
And basically that is cause an error which prevent button of reappearing when the browser is being restarted while the correct state of the icon is not being saved during toolbox.ownerDocument.persist method call.
comment:6 Changed on 05/06/2014 at 11:56:49 AM by saroyanm
Strange, I can't find BrowserToolbarPalette with DOM inspector while seams that it should be under "addon-bar" -> http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.xul#1000
Anyway in FF it's looks like that BrowserToolbarPalette is somehow hidden from toolbox while in SeaMonkey it's in toolbox and seams that it's a reason behind the issue.
See also #185.