Opened on 01/28/2015 at 09:39:36 PM

Closed on 02/10/2015 at 11:30:16 AM

Last modified on 02/10/2015 at 11:41:10 AM

#1897 closed change (fixed)

Compress auto-generated images with pngout

Reported by: sebastian Assignee: sebastian
Priority: P4 Milestone:
Module: Automation Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

​http://codereview.adblockplus.org/4663693082099712

Description (last modified by sebastian)

Background

​pngout is known to be the most efficient PNG optimizer, reducing file size of PNG files. We are used to run pngout before adding PNG files to our repositories. But some icons for Adblock Plus for Chrome/Opera/Safari are auto-generated, and therefore aren't currently optimized by pngout. However, we have quite a few auto-generated icons, which add up in file size.

What to change

Integrate pngout into the build process in order to optimize auto-generated images.

Hints for testers

Make sure that the toolbar icons on Safari are still rendered as before. Also check the icon animation on Chrome, Opera and Safari, which can be tested as described in #1965.

Attachments (0)

Change History (4)

comment:1 Changed on 01/28/2015 at 09:41:06 PM by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 01/28/2015 at 09:57:05 PM by sebastian

  • Description modified (diff)

comment:3 Changed on 02/10/2015 at 11:30:16 AM by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed

​https://hg.adblockplus.org/buildtools/rev/ffac8445f588

comment:4 Changed on 02/10/2015 at 11:41:10 AM by sebastian

  • Description modified (diff)

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sebastian.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.