Opened on 01/29/2015 at 05:05:03 PM

Closed on 01/29/2015 at 05:28:58 PM

Last modified on 02/23/2015 at 01:14:24 PM

#1906 closed defect (fixed)

Fix broken Android build

Reported by: rjeschke Assignee:
Priority: P1 Milestone: Adblock-Plus-for-Android-1.3
Module: Libadblockplus Keywords:
Cc: Blocked By:
Blocking: Platform: Android
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

​http://codereview.adblockplus.org/5708936187478016/

Description

Upgrading v8 and adding notification support broke the Android build:

  1. v8 now requires to have "arm_float_abi" defined
  2. the Notification test cases use std::tr1::make_shared which is not available on the gcc Android toolchain used for building libadblockplus

Attachments (0)

Change History (3)

comment:1 Changed on 01/29/2015 at 05:05:18 PM by rjeschke

  • Summary changed from Fixed the Android build to Fix broken Android build

comment:2 Changed on 01/29/2015 at 05:28:58 PM by rjeschke

  • Resolution set to fixed
  • Status changed from new to closed

comment:3 Changed on 02/23/2015 at 01:14:24 PM by rjeschke

  • Milestone set to Adblock-Plus-for-Android-1.3

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.